Browse Source

Taskbar11: Fixed a bug that could crash `explorer.exe` when right clicking certain system tray icons on 22621-based builds

Impact: Failure to check against a NULL value and dereferencing it
leads to a crash in `explorer.exe` with fault offset 0xfc69 on
22621-based OS builds. This happens when right clicking certain system
tray icons, like "Epic Games Launcher" when using the Windows 11
taskbar.

Description: The issue has been addressed with improved checks: a check
against NULL values is performed before attempting to work with the
data the variables might point to.
pull/1138/head
Valentin Radu 3 years ago
parent
commit
a6a88b1b87
  1. 2
      ExplorerPatcher/dllmain.c

2
ExplorerPatcher/dllmain.c

@ -2235,7 +2235,7 @@ BOOL IsPointOnEmptyAreaOfNewTaskbar(POINT pt) @@ -2235,7 +2235,7 @@ BOOL IsPointOnEmptyAreaOfNewTaskbar(POINT pt)
}
if (SUCCEEDED(hr) && bIsWindows11Version22H2OrHigher)
{
bRet = (!wcscmp(elemName, L"") && !wcscmp(elemType, L"Taskbar.TaskbarFrameAutomationPeer"));
bRet = elemName && elemType && (!wcscmp(elemName, L"") && !wcscmp(elemType, L"Taskbar.TaskbarFrameAutomationPeer"));
}
if (SUCCEEDED(hr) && !bIsWindows11Version22H2OrHigher)
{

Loading…
Cancel
Save